Plotting in Java for VCell CLI (+ Python live shell "removal" & deprecation) #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeByDrescher
force-pushed
the
PlottingUpgrade
branch
from
4b72a6c to
8e5fdc5
Compare
CodeByDrescher
force-pushed
the
PlottingUpgrade
branch
from
9cb0f33 to
7c99bd7
Compare
jcschaff
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plotting the data from in CLI had been handled by calling python functions through a python shell generated in java.
This approach had caused a number of problems, from speed to debugging difficulties, etc.
This PR deprecates the live-python client, and removes all calls to it from CLI. Instead, a java-based plotting library has been added, and tests included to ensure no functionality has been lost or damaged in the conversion process.